Fix DatePickerAndroid with mode spinner on Android Nougat(7.0) #24739
Conversation
facebook-github-bot
added
the
CLA Signed
react-native-bot
added
API: DatePickerAndroid
Platform: Android
|
@luancurti I looked into the Android issue tracker and it seems that issue exists only on Android 7.0, so it might be best to use fixSpinner on Android 7.0. Could you please change and check that it works for other versions? |
|
Hi @dulmandakh I tested only on Android Nougat but now I retested again in this Android versions 5.0, 7.0 and 9.0, and I changed this line Below are the test screenshots. Android 5.0
Android 7.0
Android 9.0
|
When mode is spinner in Android Nougat the DatePicker shows calendar
There was a problem hiding this comment.
@cpojer is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
This pull request was successfully merged by @luancurti in bb060d6. When will my fix make it into a release? | Upcoming Releases |
…ook#24739) Summary: When mode is spinner in Android Nougat the DatePicker shows calendar I got it from https://gist.github.com/jeffdgr8/6bc5f990bf0c13a7334ce385d482af9f and did some adjustments in order to work with `DatePicker`. Workaround for this bug: https://code.google.com/p/android/issues/detail?id=222208. In Android 7.0 Nougat, spinner mode for the DatePicker in DatePickerDialog is incorrectly displayed as calendar. ## Changelog [Android][Fixed] Fix date picker with mode spinner on Android Nougat (7.0) Pull Request resolved: facebook#24739 Differential Revision: D15391354 Pulled By: cpojer fbshipit-source-id: 09f45367250aa14857a9c68846c7f2ce7c49ee3b
When mode is spinner in Android Nougat the DatePicker shows calendar
Summary
I got it from https://gist.github.com/jeffdgr8/6bc5f990bf0c13a7334ce385d482af9f and
did some adjustments in order to work with
DatePicker. Workaround for this bug: https://code.google.com/p/android/issues/detail?id=222208. In Android 7.0 Nougat, spinner mode for the DatePicker in DatePickerDialog is incorrectly displayed as calendar.Changelog
[Android][Fixed] Fix date picker with mode spinner on Android Nougat (7.0)
Test Plan
Run RNTester with Simulator that has Android Nougat (7.0)
Search DatePickerAndroid
Click in Simple spinner date picker